test: add config module tests + resetConfig() - #28
Closed
TerminalGravity wants to merge 2 commits into
Closed
Conversation
… and contracts The README references .preflight/ config extensively but there were no concrete example files to copy. This adds a ready-to-use examples/.preflight/ directory with annotated config.yml, triage.yml, and contracts/api.yml, plus a README explaining how to use them.
- Add 17 tests covering config loading from .preflight/, env var overrides, caching, malformed YAML handling, and helper functions - Export resetConfig() to clear cached config (needed for tests and potential config hot-reload) - All 60 tests passing
TerminalGravity
commented
Feb 27, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
resetConfig() is exactly what was needed for test isolation. Mock strategy is solid.
One question: the test for 'ignores env vars when .preflight/ exists' — is that the intended behavior? If someone has both a config dir and env vars set, silently ignoring the env vars could be surprising. Might be worth a debug log or a note in the README.
Collaborator
Author
|
Superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 17 tests for
src/lib/config.tscovering:.preflight/dir or env varsresetConfig()cache invalidationPROMPT_DISCIPLINE_PROFILE,PREFLIGHT_RELATED,EMBEDDING_PROVIDER,OPENAI_API_KEY).preflight/config.ymlloading and merging with defaults.preflight/triage.ymlloading.preflight/existsgetRelatedProjects()andhasPreflightConfig()helpersAlso exports
resetConfig()from config module for test isolation and potential config hot-reload.All 60 tests passing.