fix: correct MCP server entry in init + add config tests - #49
Closed
TerminalGravity wants to merge 1 commit into
Closed
fix: correct MCP server entry in init + add config tests#49TerminalGravity wants to merge 1 commit into
TerminalGravity wants to merge 1 commit into
Conversation
- Fix .mcp.json generation: was using broken path (npx tsx node_modules/...), now correctly uses 'npx --package preflight-dev@latest preflight-serve' - Add bin/serve.js as dedicated MCP server entry point - Add 'preflight-serve' bin to package.json - Add 6 tests for config system (defaults, env vars, yaml loading, error handling)
TerminalGravity
commented
Mar 3, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
Node 18 failure is expected since engine requirement moved to >=20. Node 20 passes. Ready to merge — the MCP server entry fix and config tests are both solid.
Collaborator
Author
|
Closing — superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
preflight initcommand was generating a broken.mcp.jsonentry that usednpx -y tsx node_modules/preflight/src/index.ts— a path that doesn't resolve when installed via npx.Fix
bin/serve.jsas dedicated MCP server entry pointpreflight-servebin to package.jsonnpx --package preflight-dev@latest preflight-serveAlso
Added 6 tests for the config system which had zero coverage (defaults, env vars, YAML loading, error handling).
All 49 tests pass.