fix: move pattern-boost logic into triagePrompt - #53
Closed
TerminalGravity wants to merge 1 commit into
Closed
Conversation
patternMatchCount was declared in TriageConfig but never used inside triagePrompt — the boost was applied externally in preflight-check.ts. This meant any other caller of triagePrompt wouldn't get pattern-aware classification. Now triagePrompt itself handles the boost: if patternMatchCount > 0 and the prompt would otherwise be 'clear', it bumps to 'ambiguous' so the caller gets a warning about known pitfalls. - Move pattern loading before triage call in preflight-check.ts - Pass patternMatchCount through triageConfig - Remove redundant external boost logic - Add proper tests (replaces the placeholder test that just checked types) Closes partially: #8 (smart triage classification)
TerminalGravity
commented
Mar 3, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
Clean refactor. Moving the pattern-boost into triagePrompt itself is the right call — having it external meant anyone else calling triage directly would miss it. The test coverage here is important since this was previously untested behavior.
Collaborator
Author
|
Closing — superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
patternMatchCountwas declared inTriageConfigbut never actually used insidetriagePrompt— the boost was applied externally inpreflight-check.ts. Any other caller oftriagePromptwouldn't get pattern-aware classification.Changes
triagePromptnow handles the boost internally: ifpatternMatchCount > 0and prompt would beclear, bumps toambiguouspreflight-check.tsRelates to #8