test: add prompt_score tests + fix scope scoring bug - #55
Closed
TerminalGravity wants to merge 1 commit into
Closed
Conversation
- Add 14 tests for scorePrompt covering all scoring dimensions - Fix bug: long prompts (>100 chars) no longer get full scope score just for being verbose — now requires domain terms (file/function/etc) - Export scorePrompt for testability
TerminalGravity
commented
Mar 3, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
Good catch on the scope scoring bug — verbose prompts getting full scope credit just for length was definitely wrong. The domain-term check is the right fix. 14 new tests covering all dimensions is thorough.
Collaborator
Author
|
Superseded by #66 which has the same fix plus more complete test coverage. Closing. |
Collaborator
Author
|
Superseded by #66. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 57 tests pass.