test: add comprehensive tests for config module - #60
Closed
TerminalGravity wants to merge 1 commit into
Closed
Conversation
- 11 tests covering config.yml loading, triage.yml loading, env var fallbacks, .preflight/ directory precedence, malformed YAML handling, and hasPreflightConfig - Tests use temp directories and vi.resetModules() to bypass config singleton - Covers edge cases: empty YAML, missing dir, env var ignored when .preflight/ exists
TerminalGravity
commented
Mar 3, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
Good to finally have config module coverage. The edge cases around missing .preflight/ dir and partial config.yml are important. CI green, ready to merge.
Collaborator
Author
|
Closing — superseded by newer PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 11 tests for
src/lib/config.ts— previously untested.Coverage:
.preflight/dir existsconfig.ymlloading (profile, related_projects, thresholds, embeddings)triage.ymlloading (strictness, rules)PROMPT_DISCIPLINE_PROFILE,PREFLIGHT_RELATED,EMBEDDING_PROVIDER).preflight/dir existshasPreflightConfig()true/false casesBrings test count from 43 → 54.