refactor: extract preflight_check helpers + add 19 tests - #71
Open
TerminalGravity wants to merge 2 commits into
Open
refactor: extract preflight_check helpers + add 19 tests#71TerminalGravity wants to merge 2 commits into
TerminalGravity wants to merge 2 commits into
Conversation
Adds Ollama as a local embedding provider option. Uses the /api/embed endpoint with batch support. Defaults to nomic-embed-text model. Configurable base URL, model name, and dimensions for flexibility with different Ollama models. Closes #6
- Extract extractFilePaths, detectAmbiguity, estimateComplexity, splitSubtasks into src/lib/preflight-helpers.ts - Update preflight-check.ts to import from shared module - Add 19 tests covering all extracted helpers - All 66 tests pass, build clean
TerminalGravity
commented
Mar 5, 2026
TerminalGravity
left a comment
TerminalGravity
left a comment
Collaborator
Author
There was a problem hiding this comment.
19 new tests + cleaner helper extraction — this is the kind of refactor that pays dividends. CI green. Ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts pure helper functions from preflight-check.ts into src/lib/preflight-helpers.ts for testability. Adds 19 tests.
Partial progress on #7