Skip to content

fix: preserve cross-service hits in multi-step triage results - #74

Open
TerminalGravity wants to merge 2 commits into
mainfrom
fix/triage-cross-service-in-multistep
Open

fix: preserve cross-service hits in multi-step triage results#74
TerminalGravity wants to merge 2 commits into
mainfrom
fix/triage-cross-service-in-multistep

Conversation

@TerminalGravity

Copy link
Copy Markdown
Collaborator

Previously triagePrompt() checked multi-step before cross-service and returned early, discarding cross_service_hits. Now cross-service detection runs first so its results are included in the multi-step return.

This ensures preflight_check can surface related project context even when the prompt is also multi-step.

  • 2 new tests covering the combined case
  • All 64 tests pass
  • Clean build

Covers JSONL parsing, event extraction, correction detection, timestamp
normalization (epoch s/ms/ISO), sub-agent spawn detection, compaction
events, malformed line handling, findSessionFiles, and async parser
parity. Brings total test count from 70 to 89.
Previously, triagePrompt() checked multi-step before cross-service and
returned early, discarding cross_service_hits. Now cross-service detection
runs first and its results are included in the multi-step return value.

This ensures preflight_check can surface related project context even
when the prompt is also multi-step.

Added 2 tests covering the combined case.

@TerminalGravity TerminalGravity left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-service hit preservation is important for multi-repo triage. CI green, looks solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant