Open
Conversation
Owner
|
Hey Dolf, Apologies for the late reply. Are you saying this solves a problem you were having, or are just preferring the aesthetics of having the methods on Key be pointer receivers? If it's the latter, I'm not against it per se, but none of those methods change the state of the Key so making them value receivers made more sense to me. |
Contributor
Author
That I'm not sure about anymore :) Advantages of using pointer receivers is that otherwise the struct would be copied for every method invocation. There was a nice blogpost that I'm thinking of but can't find it right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging an issue I added the pointer receivers. I'm not sure if that's what made the difference, but it seems a good improvement nonetheless.