Revert eval to exported package. Used in cre.#69
Merged
scunningham merged 1 commit intomainfrom Jan 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request moves the eval package from internal/pkg/eval to pkg/eval, making it available as an exported package for external use. The PR title mentions this is needed for use in "cre" (likely referring to an external consumer).
Changes:
- Moved eval package from internal to public API surface
- Updated all import references from
internal/pkg/evaltopkg/eval - Added defensive nil check for config parameter in the exported
Detectfunction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/preq_test.go | Updated import path to use the new exported eval package |
| cmd/wasm/wasm.go | Updated import path to use the new exported eval package |
| pkg/eval/eval.go | Added nil check for config parameter to make the exported API more robust |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tonymeehan
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.