Document UpdatePikachuHappinessAndMood routine#155
Merged
Conversation
Named unnamed labels.
Rangi42
requested changes
Jun 6, 2026
Rangi42
left a comment
Rangi42
left a comment
Member
There was a problem hiding this comment.
These labels seem locally accurate -- e.g. yes .done is at the "done" position within the routine -- but they don't actually document why any of the function's possible behavior cases are happening. It probably needs some more research into what contexts this function gets called under, and add some comments, not just labels. Compare with how ApplyOutOfBattlePoisonDamage right above here explains why it does what it does.
Rangi42
changed the title
UpdatePikachuHappinessAndMood routine
Member
|
(Also fixed the PR name from the default edited-a-file-on-GitHub-online name.) |
Document further and better the function that modifies Pikachu's happiness and mood by walking
Rangi42
reviewed
Jun 7, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named unnamed labels.