Use OAM constants#157
Merged
Merged
Conversation
Rangi42
requested changes
Jun 20, 2026
Rangi42
left a comment
Rangi42
left a comment
Member
There was a problem hiding this comment.
Thanks for this! While you're editing the file anyway, a couple of requests:
- Just use
0instead ofOAM_PAL0; it's more consistent with how the GBC disassemblies use plain0-7for palette indexes (unless they're for specific palette tables like the overworld tiles or battle anims). - Please use base 10 for the X and Y coords, e.g.
4not$04and-4not$fc.
Contributor
Author
|
Thanks for the feedback! I also tried some relabelling. Let me know if there's something else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.