Refactor BillsHouse and Pikachu movement#158
Merged
Merged
Conversation
kqesar
commented
Jun 19, 2026
kqesar
commented
Contributor
- Rename wd471 to wPikachuSpawnStateFlags globally
- Rename wd492 to wPikachuMapScriptFlags globally
- Introduce pikachu_movement_constants.asm
- Refactor BillsHouse scripts and Pikachu/Bill movement data
kqesar
force-pushed
the
refactor-bills-house
branch
from
0dbe838 to
4e0644e
Compare
Rangi42
requested changes
Jun 20, 2026
kqesar
force-pushed
the
refactor-bills-house
branch
2 times, most recently
from
5fa8be5 to
8deede9
Compare
Rangi42
requested changes
Jun 23, 2026
Rangi42
left a comment
Rangi42
left a comment
Member
There was a problem hiding this comment.
Thanks for identifying the bit flags! I've commented a few more places they could be used.
- Rename wd471 to wPikachuSpawnStateFlags globally - Rename wd492 to wPikachuMapScriptFlags globally - Introduce pikachu_movement_constants.asm - Refactor BillsHouse scripts and Pikachu/Bill movement data
kqesar
force-pushed
the
refactor-bills-house
branch
from
eb5c6cf to
36811a8
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 24, 2026
… and `PIKAMOVEMENT_*` constants (#158) - Rename `wd471` to` wPikachuSpawnStateFlags`, with `BIT_PIKACHU_SPAWN_*` bits - Rename `wd492` to `wPikachuMapScriptFlags`, with `BIT_PIKACHU_MAP_*` bits - Introduce `PIKAMOVEMENT_*` constants for `ApplyPikachuMovementData` - Refactor `BillsHouse` scripts and Pikachu/Bill movement data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.