feat: Checkout Components#331
Open
OnurVar wants to merge 42 commits into
Open
Conversation
Generated by 🚫 Danger Swift against 50f61b8 |
Generated by 🚫 Danger Kotlin against 50f61b8 |
|
Appetize iOS link: https://appetize.io/app/v6fw3aqdz4j4u2u3v5o2czx7xi |
|
Appetize Android link: https://appetize.io/app/jwor3dpopkjftxfgtf4gtoveta |
OnurVar
force-pushed
the
ov/feat/components
branch
2 times, most recently
from
f97972f to
d47d336
Compare
OnurVar
force-pushed
the
ov/feat/components
branch
2 times, most recently
from
f69fdb6 to
09ef1a0
Compare
OnurVar
force-pushed
the
ov/feat/components
branch
from
441f66f to
e897c92
Compare
v3 (#1250) renamed EventType to AnalyticsEvent in components-analytics. Update AnalyticsEventMapper and the DefaultNativePrimerModule call site.
OnurVar
force-pushed
the
ov/feat/components
branch
from
b9931e4 to
4b2ae71
Compare
iOS PrimerSDK -> 3.0.0-beta.1, Android io.primer:* -> 3.0.0-beta.3, both now on CocoaPods / Maven Central. Removes the need for local :path / mavenLocal wiring; components-bridge beta.2 was never published to Central.
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found.
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
Re-resolved after the podspec bump. Pulls the new 3.0 subpods (PrimerNetworking, PrimerResources, PrimerUI) from CocoaPods; no :path overrides.
This repo doesn't transform node_modules, so real react-native is raw ESM. Component tests hand-mocked react-native per file; once the component graph got deep (post-#381 rename) those mocks leaked on the Linux CI runner — the real, untransformed react-native loaded and Node threw "Cannot use import statement outside a module" (non-deterministically, never locally). Add one auto-applied mock at __mocks__/react-native.js (jest uses manual mocks adjacent to node_modules for every test) so real react-native is never loaded, and drop the bespoke leak-prone factories (cardInputGuard used the buggy virtual:true) from the two suites that render deep component trees.
Swipe-to-dismiss fired onDismiss before onRequestDismiss (reversed vs every other dismiss path) and self-hid the sheet even when no onRequestDismiss was provided, desyncing it from the parent's visible prop (hidden but visible=true, unable to reopen until toggled off/on). Fire onRequestDismiss first, then onDismiss; and spring back instead of dismissing when onRequestDismiss is absent — matching handleBackdropPress.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.