float_sz support for round-trip float (de)serialization - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, byte-level round-tripping was only guaranteed for f64-encoded floats. An f16/f32-encoded float decodes to f64
This PR updates it to support round-trip (de)serialization for f16 and f32 as well
To achieve this, I have Fable 5 write the code, and then brute-for test every possible f16 and f32 representation possible on my computer to check they all round-trip
float16_exhaustive_byte_roundtriptest since it's fast#[ignore]after running it locally (since it's a long test)The reason I need this is that some projects I care about for cddl-codegen use
anyand therefore I need anAnyCbor(but doing so without float support gets kind of hacky and it was easier to just add float support upstream)This closes #16