fix(cli): resolve Windows Alchemy executable shims - #280
Draft
AmanVarshney01 wants to merge 2 commits into
Draft
Conversation
Regression intentionally fails on Windows until resolver supports installed cmd/exe shims. Existing POSIX resolver tests pass. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
commit: |
Local resolver/runner tests and CLI typecheck pass. Windows execution is verified by the existing CI matrix, pending at commit time. Signed-off-by: Aman Varshney <amanvarshney.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Composer only looked for node_modules/.bin/alchemy. Windows package managers can install alchemy.exe or alchemy.cmd without that extensionless file, so Composer incorrectly reports DEPLOY.ALCHEMY_BIN_MISSING before launching anything.
Fix
Resolve the nearest installed Windows executable in order: alchemy.exe, alchemy.cmd, then the extensionless shim. Continue searching ancestors for hoisted installations; POSIX behavior is unchanged. No PATH/global fallback, application workaround, or dependency change. Update the deployment guide and core-concepts skill with the resolution contract.
Verification
Related owning-repo fix
prisma/prisma-cli#250 fixes the consolidated CLI adapter that launches the resolved command. Its native Windows regression reproduced spawn EINVAL on npm.cmd before the fix.
Limits
This does not claim all Windows assembly or deployment failures share this cause, or enable local Windows dev support. No production deployment was performed for this change.