Skip to content

chore: CI - build - reusable workflow artifacts #28122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dulmandakh wants to merge 2 commits into
base: v7
Choose a base branch
from
Open

chore: CI - build - reusable workflow artifacts #28122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73a92ca
chore: CI - build workflow
dulmandakh Oct 9, 2025
4f249a6
remove bundle-size paths-ignore
dulmandakh Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ runs:
using: composite
steps:
- uses: pnpm/action-setup@v4.0.0

- name: Cache turbo build setup
uses: actions/cache@v4
with:
path: .turbo
key: ${{ runner.os }}-node-${{ inputs.node-version }}-turbo-${{ github.sha }}

Copilot AI Oct 9, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using github.sha in the cache key means each commit will create a new cache entry, preventing cache reuse across commits. Consider using a more stable key like ${{ hashFiles('**/pnpm-lock.yaml', 'turbo.json') }} to enable cache sharing between commits with the same dependencies and turbo configuration.

Suggested change
key: ${{ runner.os }}-node-${{ inputs.node-version }}-turbo-${{ github.sha }}
key: ${{ runner.os }}-node-${{ inputs.node-version }}-turbo-${{ hashFiles('**/pnpm-lock.yaml', 'turbo.json') }}

Copilot uses AI. Check for mistakes.
restore-keys: |
${{ runner.os }}-node-${{ inputs.node-version }}-turbo-

- name: Use Node.js ${{ inputs.node-version }}
uses: actions/setup-node@v4
with:
Expand All @@ -29,7 +38,7 @@ runs:
# The NPM_TOKEN secret needs to be defined in the job
registry-url: 'https://registry.npmjs.org'

- run: pnpm install
- run: pnpm install --prefer-offline
shell: bash

- run: pnpm -r run dev
Expand Down
23 changes: 23 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Build

on:
pull_request:

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: ['18', '20', '22', '24']

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Install & build
uses: ./.github/actions/setup
with:
node-version: ${{ matrix.node-version }}
skip-tsc: false
skip-build: false
25 changes: 7 additions & 18 deletions .github/workflows/bundle-size.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,10 @@
name: Bundle size

on:
pull_request:
paths-ignore:
# Any update here needs to be done for all files
# (test.yml, benchmark.yml, release-ci.yml, bundle-size.yml, ci-aux-files.yml)
- '*.md'
- '*.bench.ts'
- 'LICENSE'
- '.dockerignore'
- 'scripts/ci/publish.ts'
- '.github/CODEOWNERS'
- '.github/ISSUE_TEMPLATE/**'
- '.github/DISCUSSION_TEMPLATE/**'
- '.devcontainer/**'
- '.vscode/**'
- 'graphs/**'
- 'sandbox/**'
workflow_run:
workflows: [Build]
types:
- completed

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -25,6 +13,7 @@ concurrency:
jobs:
size:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}

steps:
- uses: actions/checkout@v4
Expand All @@ -33,8 +22,8 @@ jobs:
uses: ./.github/actions/setup
with:
node-version: 18
skip-tsc: true
skip-build: true
skip-tsc: false
skip-build: false
Comment thread
aqrln marked this conversation as resolved.

- uses: andresz1/size-limit-action@v1
with:
Expand Down