test: add coverage for storage-entry-schemas.ts narrow validation - #30184
Open
EmaToplek wants to merge 1 commit into
Open
test: add coverage for storage-entry-schemas.ts narrow validation#30184EmaToplek wants to merge 1 commit into
EmaToplek wants to merge 1 commit into
Conversation
Signed-off-by: EmaToplek <toplek.ema0213@outlook.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughChangesStorage schema validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds focused tests for existing storage schema validation behavior and does not alter production behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for the
.narrow()validation callback onStorageColumnSchemainpackages/2-sql/1-core/contract/src/ir/storage-entry-schemas.ts, covering:the
typeParams/typeRefmutual-exclusivity checkthe
noCheckarray non-empty requirementthe
noChecksorted/unique-ascending requirementstorage-entry-schemas.ts: 100% statements/branches/functions/lines (up from 73%/38%/100%/76%)Related to the M9 target-extensible-IR coverage gap noted in
coverage.config.json(TML-2521).Summary by CodeRabbit