Open
Conversation
* Use cfg-if to select a single implementation * Add a note in the README that macOS needs to select an implementation.
Contributor
|
I wrote my reaction to the opinions in #237 (comment) — but tl;dr I like the approach in this PR. |
Contributor
|
It could be interesting to add a test in the github actions to ensure this behavior isn't broken later ( |
Author
Contributor
|
There are test errors in CI, but they look unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
native-tlsis set as a default feature, but selecting a different tls implementation requiresdefault-features = falsein your Cargo.toml.This PR will select one of the alternatives in alphabetical order, so that if you ask for
features = ["vendored-openssl", "rustls", "native-tls"]you will get the implementation forrustls.This solves a similar issue to #237, but uses
cfg-ifin order to just surface a single implementation where necessary.