Skip to content

testing with matrix exculde#39

Open
mohitulm wants to merge 21 commits into
mainfrom
application_test
Open

testing with matrix exculde#39
mohitulm wants to merge 21 commits into
mainfrom
application_test

Conversation

@mohitulm
Copy link
Copy Markdown
Collaborator

@mohitulm mohitulm commented Aug 3, 2024

Description

Motivation and Context

How Has This Been Tested?

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix
  • New feature
  • Breaking change (Causes existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in /docs/changelog.rst.
  • My change requires additional/updated documentation.
  • I have updated the documentation accordingly.
  • I have added/updated the config example for any module docstrings as necessary.
  • I have checked that the change does not contain obvious errors
    (syntax, indentation, mutable default values, etc.).
  • I have tested my changes using 'Load all modules' on the default dummy configuration.
  • All changed Jupyter notebooks have been stripped of their output cells.

@prithviulm
Copy link
Copy Markdown
Owner

Great work! The 'official' fix for the deadlock has been approved in Ulm-IQO#108 so it should be merged shortly

@prithviulm
Copy link
Copy Markdown
Owner

prithviulm commented Aug 30, 2024

I've updated the main branch of this fork since Ulm-IQO#108 has been merged.

Copy link
Copy Markdown
Owner

@prithviulm prithviulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread pyproject.toml
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify a minimum version for these packages?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually why do we need opencv-python-headless?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants