Ability to use multiple provider files.#50
Open
pczajkowski wants to merge 4 commits intoproabiral:masterfrom
Open
Ability to use multiple provider files.#50pczajkowski wants to merge 4 commits intoproabiral:masterfrom
pczajkowski wants to merge 4 commits intoproabiral:masterfrom
Conversation
Contributor
Author
|
The other option I see would be to pass delimited list of files to |
Owner
|
Hi @pczajkowski , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is interesting request (#34), so I've went ahead and implemented it. The only sensible way to do it IMHO is by utilizing
flag.Args()and because of that the program should be called with-providerparameter and additional provider JSONs at the end, like./inception -d list -provider provider.json provider2.json provider3.json provider4.json.I also believe that with multiple files it's better to not crash on read/unmarshalling failure, so I've modified
errCheckJSONand addederrCheckInfo, so thatos.Exit(1)won't be called. But I'm not insisting I'm right here.It's quite a change and I'm not 100% satisfied with this solution, but at this point I don't see other option.