Publish Serial and IO libraries to Maven Central #1421
Conversation
|
@Stefterv hey good evening, I’ve opened the PR as discussed. Please let me know if any changes are needed Thanks |
| dependencies { | ||
| compileOnly(project(":core")) | ||
| // TODO: https://github.com/java-native/jssc | ||
| implementation(files("library/jssc.jar")) |
|
@Stefterv hey... saw that TODO was left there in #1106. At the time there wasn't a good public version. Looks like If there's something from the old fork that still needs to be there pls let me knw |
|
Oh great, can you separate that out into a 2nd PR? I will need to look a bit deeper into that and don't want to block this one. |
|
@Stefterv sure you re right, gimme a moment |
|
@Stefterv Done, PR now only has the IO library migration. will open a separate PR for the jssc migration later as you asked. Pls let me know |
|
Ah, please keep the work you did on publishing the serial library, just keep the jssc jar like it was 😅 |
|
@Stefterv oh alright, give me some time college chaos ongoing 🥀 |
|
@avinxshKD lgtm! if @Stefterv is happy with it, let's get this merged in |
3 participants
Ported Serial and IO libraries from Ant to Gradle with Maven publishing, Serial now uses upstream jssc from Maven Central instead of the bundled fork. This completes the library migration work started in #1407 and #1411.
closes #1403