fix(tooltip): stable hover, elevated surface, seamless arrow#905
Merged
Conversation
- Scope the scroll-dismiss to scrolls whose target holds the trigger, so an unrelated scroll (e.g. the message list auto-scrolling to bottom when the main view mounts) no longer yanks a visible tooltip away. Applied the same guard to UserInfoPopover. - Use the elevated float surface (bg-fluux-float) instead of the sidebar color so tooltips read clearly against very dark backgrounds. - Rebuild the arrow as a seamless half-diamond: a rotated square painted over the bubble with a border only on its two outer edges, replacing the borderless triangle that looked broken and vanished on dark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues with the shared
Tooltip(surfaced on the icon-rail nav tooltips):windowscroll listener that fired for any scroll — so the message list auto-scrolling to the bottom on view mount killed a visible tooltip. Now it only dismisses when the scrolled element actually contains the trigger. The same over-broad pattern inUserInfoPopovergot the identical guard.bg-fluux-sidebar, only one step above the chat content, so it read only via a faint border/shadow. Switched to the app's elevated float surface (bg-fluux-float) — the same surface popovers/menus use — so it clearly reads in dark mode and stays consistent in light mode.