Stabilize own-message hover toolbar position; align emphasis to hover row#921
Merged
Conversation
…ver row The own-message tint hugs its content (`w-fit`), and the hover toolbar was anchored inside that box — so a short own message pulled its action menu far from the row edge, and the emphasis bottom floated a few px above the hover-row highlight. - Move the toolbar into a full-width positioning column that wraps the hugging tint box, so it pins to the row's right edge for every message regardless of bubble width (matching incoming rows). - Extend `.message-own-tint-end` down through the row's group-end padding so the emphasis bottom meets the hover-row highlight. padding-bottom paints the wash lower; an equal negative margin-bottom cancels it so row heights (and the virtualizer's measurements) are unchanged. Mirrors `.message-group-end`, including the compact-density override. Adds regression tests: toolbar anchoring (DOM structure) and the CSS mirror invariant between `.message-own-tint-end` and `.message-group-end`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The own-message tint hugs its content (
w-fit), and the hover toolbar was anchored inside that box — so a short own message (e.g. "dommage") pulled its action menu far from the row edge, and the emphasis bottom floated a few px above the hover-row highlight.Toolbar position — moved the toolbar into a full-width positioning column that wraps the hugging tint box, so it pins to the row's right edge for every message regardless of bubble width (now matching incoming rows, all toolbars align in one right column).
Emphasis bottom — extended
.message-own-tint-enddown through the row's group-end padding so the emphasis bottom meets the hover-row highlight.padding-bottompaints the wash lower; an equal negativemargin-bottomcancels it so row heights (and the virtualizer's measurements) are unchanged. Mirrors.message-group-end, including the compact-density override.