Reserve space for the typing indicator instead of overlaying it#924
Merged
Conversation
The floating typing pill (#918) could cover the last message when the reader was at the bottom of a conversation. The footer now reserves a constant idle padding, and grows just enough to clear the pill only while it's shown and the reader is genuinely sticked to the bottom — gated on live geometry so a reader scrolled up into history is never re-pinned, preserving the #918 fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The floating typing pill (#918) could overlay and hide the last message when the reader is at the bottom of a conversation. The footer now reserves a small constant idle padding (
pb-4) that grows just enough to clear the pill (pb-12) only while it's shown — and only nudges the view when the reader is genuinely sticked to the bottom, gated on live geometry rather than the latchableisAtBottomRefso a reader scrolled up into history is never re-pinned (preserving the #918 fix).