Icon-style build switch: hollow outline default, plain glass opt-in#928
Open
mremond wants to merge 9 commits into
Open
Icon-style build switch: hollow outline default, plain glass opt-in#928mremond wants to merge 9 commits into
mremond wants to merge 9 commits into
Conversation
Also correct the spec: pin the historical MessageCircle path (installed lucide-react 1.16 redesigned it) and use an absolute-1024-space drop shadow on an unscaled wrapper (Cairo/Skia renderer consistency).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a build-time switch (
VITE_FLUUX_ICON_STYLE) that selects the app's chat-bubble icon treatment across everything — the login mark, the native desktop/dock/taskbar/installer icons, the PWA icons, and the favicon — in one build.hollow(new default): a white outline chat bubble on the aurora gradient tile — the mark from Reuse round empty chat bubble logo consistently across the app #910 that people liked.plain: the existing glass-fill bubble (still carries the Fix white seam at chat-bubble tail junction in app icon #926 seam fix).The gradient is unchanged; only the glyph differs.
How it works
LoginScreen.tsxreadsimport.meta.env.VITE_FLUUX_ICON_STYLEat render time (same pattern asVITE_SHOW_LOGO) and rendersHollowIconMarkorAppIconMark.scripts/select-icon-variant.mjs(wired viapredev/prebuild/pretauri:*) copies a committedicon-variants/{plain,hollow}/dist/tree over the live icon locations. Default/unset/unknown → hollow; onlyplainopts out.generate.sh [plain|hollow|all]regenerates them. A guard test asserts the committed live icons stay byte-identical toicon-variants/hollow/dist.Usage:
VITE_FLUUX_ICON_STYLE=plain npm run tauri:buildfor the glass variant; default builds are hollow.Design/plan:
docs/superpowers/specs/2026-07-08-icon-style-build-switch-design.md.Closes #910.