Closed
Conversation
Fixes based on [failures](https://github.com/procore-oss/ruby-sdk/actions/runs/14200642357/job/39786502330?pr=81#step:6:5) There is also a warning when you run `COVERAGE=true bundle exec rake` about many new cops available. That's for another PR - [x] added .tool-versions (asdf) to gitignore Signed-off-by: jmeridth <jmeridth@gmail.com>
martinr23
approved these changes
Apr 3, 2025
stevenbjohnson
approved these changes
Apr 7, 2025
Contributor
Author
|
@njbbaer can you please give this a once over and a merge? It will fix tests and let other PRs merge. |
Contributor
Author
|
@lessthanjacob are you able to approve and merge? |
Contributor
Author
|
@lessthanjacob @njbbaer check in the mail? 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes based on failures
There is also a warning when you run
COVERAGE=true bundle exec rakeabout many new cops available. That's for another PRChecklist: