Skip to content

test(abort-reason): de-flake using synthetic transport rejection (follow-up to #120) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
productdevbook merged 1 commit into from
May 3, 2026
Merged

test(abort-reason): de-flake using synthetic transport rejection (follow-up to #120) #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions test/abort-reason.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,16 @@ describe("abort signals — reason propagation", () => {
})

it("our own timeout fires TimeoutError, not AbortError", async () => {
// The contract under test is the *shape* of the rejection (mapped to
// TimeoutError, not AbortError), not the wall-clock behavior of
// `AbortSignal.timeout`. Driving the rejection synchronously with a
// TimeoutError-named DOMException exercises the same `mapTransportError`
// path while removing the real-timer race that flaked under saturated CI
// runners (same flake class as #120 / fixed in #122).
const driver = {
name: "slow",
request: (req: Request) =>
new Promise<Response>((_resolve, reject) => {
req.signal.addEventListener("abort", () => {
reject(req.signal.reason ?? new DOMException("aborted", "AbortError"))
})
}),
request: (_req: Request) =>
Promise.reject(new DOMException("Operation timed out", "TimeoutError")),
}

const m = createMisina({ driver, retry: 0, timeout: 20 })
Expand Down
Loading