Team Turing Whiteboard final version#241
Open
isilien wants to merge 142 commits intoprofessor:masterfrom
Open
Conversation
Owner
There was a problem hiding this comment.
Why can't we re-use one of the existing user factories? If we need a good one, please use normal syntax: student_test_user
app/models/deliverable.rb
Outdated
Owner
There was a problem hiding this comment.
This method is getting very long. How do we simplify? I suspect we need to move the sql into helper methods.
…ng and removing invalid grading queue service
…ng and removing invalid grading queue service
…efactored according to @professor suggestions.
… of filter_deliverables
…s controller to return all deliverables when no filter is pressed
…ables and update_feedback deliverables_controller actions
… page and grade book
… default value is not changed. Code clean up in grading queue view
… default value is not changed.
…eboard, but will miss more my great team Turing
Author
|
Whiteboard grading queue ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready!