Open
Conversation
Fixed typo in peer_evaluation_learning_objective spec
reports, reviews) from mass assignment using attr_accessible
assignment - done until possibly after our meeting with Todd tomorrow
test is incomplete
Build is currently broken
Note: I don't think this protects job_employee's job_id needs further investigation
Fixed a bug in jobs controller: can now remove ALL employees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protected against mass assignment (via strong_parameters gem) in effort_logs, effort_log_line_items, job_employees, job_supervisors, peer_evaluation_learning_objectives, peer_evaluation_report, peer_evaluation_review
Fixed a bug in jobs_controller: could not remove ALL employees once any employees had been added