Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/cli/src/commands/iterate-options.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import { InvalidArgumentError } from 'commander';

export function parsePositiveSafeInteger(value: string): number {
// Only accept plain decimal digit strings. Number() would otherwise coerce
// scientific ("1e2"), hexadecimal ("0x10"), binary/octal, signed ("+60"), and
// whitespace-padded values into numbers, which are not valid interval inputs.
if (!/^\d+$/.test(value)) {
throw new InvalidArgumentError('must be a positive safe integer');
}
const parsed = Number(value);
if (!Number.isSafeInteger(parsed) || parsed < 1) {
throw new InvalidArgumentError('must be a positive safe integer');
Expand Down
7 changes: 7 additions & 0 deletions packages/cli/src/commands/iterate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ describe('parsePositiveSafeInteger', () => {
expect(() => parsePositiveSafeInteger(value)).toThrow('positive safe integer');
},
);

it.each(['1e2', '0x10', '0b10', '0o10', '+60', ' 60', '60 ', '1_000'])(
'rejects non-decimal numeric interval %s',
(value) => {
expect(() => parsePositiveSafeInteger(value)).toThrow('positive safe integer');
},
);
});

describe('parseQuietHours', () => {
Expand Down