fix(chat-whatsapp): require clean graph api origin#811
Merged
ralyodio merged 1 commit intoJul 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens validation for the chat-whatsapp target’s graphApiBaseUrl configuration to ensure it is a clean HTTPS origin before Graph API endpoint URLs are constructed, reducing the risk of malformed requests or accidental query/credential leakage.
Changes:
- Enforce that
graphApiBaseUrlis a clean HTTPS origin (no credentials, path, query, or hash). - Normalize the base URL by returning
URL.origininstead of trimming trailing slashes. - Add a test case asserting rejection of a base URL containing a query string.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/targets/chat-whatsapp/src/index.ts | Strengthens graphApiBaseUrl validation to require a clean HTTPS origin and returns parsed.origin. |
| packages/targets/chat-whatsapp/src/index.test.ts | Adds coverage for rejecting a non-origin graphApiBaseUrl containing a query string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
92
to
101
| await expect(adapter.build(fakeBuildContext() as any, { | ||
| ...baseConfig, | ||
| graphApiBaseUrl: 'http://graph.facebook.com', | ||
| })).rejects.toThrow('graphApiBaseUrl must use HTTPS'); | ||
|
|
||
| await expect(adapter.build(fakeBuildContext() as any, { | ||
| ...baseConfig, | ||
| graphApiBaseUrl: 'https://graph.facebook.com/api?token=leak', | ||
| })).rejects.toThrow('graphApiBaseUrl must be an HTTPS origin'); | ||
| }); |
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: running through pnpm in this workspace currently triggers an unrelated lockfile policy failure for @profullstack/autoblog@0.4.0 missing tarball integrity, so I ran the local Vitest and TypeScript binaries directly.