fix(payment-square): validate refund amount money#812
Merged
ralyodio merged 1 commit intoJul 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Square payment target’s refund command by validating refund amount_money inputs before calling Square and ensuring the refund payload matches Square’s expected Money shape.
Changes:
- Validate refund
amountas a positive integer and normalizecurrencyto a 3-letter uppercase ISO code. - Send
amount_moneyas{ amount, currency }for refunds (consistent withcreate). - Add Vitest coverage for a valid refund payload and for rejecting invalid refund amounts before any API call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/targets/payment-square/src/index.ts | Adds refund amount/currency validation and normalizes amount_money payload. |
| packages/targets/payment-square/src/index.test.ts | Adds tests covering validated refund payloads and invalid refund amount rejection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| payment_id: id, | ||
| amount_money: config.args?.amount, | ||
| amount_money: { amount, currency }, | ||
| reason: (config.args?.reason as string) || 'requested_by_customer', |
|
🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: running through pnpm in this workspace currently triggers an unrelated lockfile policy failure for @profullstack/autoblog@0.4.0 missing tarball integrity, so I ran the local Vitest and TypeScript binaries directly.