fix(dns-porkbun): reject non-decimal ttl strings#813
Merged
ralyodio merged 1 commit intoJul 22, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens TTL parsing for the Porkbun DNS adapter so only positive decimal integer TTLs are accepted, and malformed TTL strings fall back to the configured/default TTL.
Changes:
- Added a dedicated
parsePorkbunTtlhelper to validate/parse TTLs from Porkbun records. - Updated record-mapping logic to use the parsed TTL (or fall back to configured/default TTL).
- Added a regression test covering non-decimal TTL string formats (
1e2,0x10, fractions) while preserving normal decimal TTL behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/dns/porkbun/src/index.ts | Adds strict TTL parsing and uses it when mapping Porkbun records into DnsRecords. |
| packages/dns/porkbun/src/index.test.ts | Adds a regression test to ensure malformed TTL strings fall back to the configured/default TTL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+74
to
+76
| if (typeof ttl === 'number') { | ||
| return Number.isInteger(ttl) && ttl > 0 ? ttl : undefined; | ||
| } |
Comment on lines
+77
to
+82
| if (typeof ttl !== 'string' || !/^[1-9]\d*$/.test(ttl)) { | ||
| return undefined; | ||
| } | ||
| const parsed = Number(ttl); | ||
| return Number.isSafeInteger(parsed) ? parsed : undefined; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1e2,0x10, or decimal fractionsVerification
node_modules/.bin/vitest.cmd run packages/dns/porkbun/src/index.test.tsnode_modules/.bin/tsc.cmd -p packages/dns/porkbun/tsconfig.json --noEmitgit diff --check