Add in-memory spatial grid index for point queries - #10
Merged
Merged
Conversation
Point queries now narrow the candidate set via a uniform-grid index over shape bounding boxes (broad phase) instead of scanning every stored shape, then refine with inShape in parallel. Shapes spanning more than 64 cells are kept in an overflow list to bound index memory. Adds BoundingBox value type and getBounds() to the sealed Shape hierarchy; Store gains queryContaining().
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point queries currently scan every stored shape (in parallel). This PR narrows the candidate set with an in-memory uniform-grid index over shape bounding boxes (broad phase), then refines with
inShapein parallel.Changes
ShapeIndex: uniform grid keyed by packed cell coordinates; a query checks only the cell containing the point. Shapes spanning more than 64 cells are kept in an overflow list checked by every query, bounding index memory for very large shapes.BoundingBoxvalue type;getBounds()added to the sealedShapehierarchy (circle/donut/triangle).StoregainsqueryContaining(Point);ObjectStorekeeps the index in sync withput/clearand rebuilds it from the DB on startup.PointCommandqueries through the index; output order stays deterministic (encounter order of the parallel stream is preserved).ShapeIndexTest(cell lookup, multi-cell overlap, overflow bucket, determinism, clear) +ObjectStoreTestquery test + updatedPointCommandTest.Verification
mvn clean test).exec:javareturns the containing shapes.