Polish: README accuracy, Point value semantics, dead-code removal - #11
Merged
Merged
Conversation
… remove dead branch - README: fix Example session output (capital Shape, => prefix on point-query lines, triangle/donut toString formats, corrected area precision) to match actual program output. - Point: add equals/hashCode/value semantics for correct behavior in collections and mocks. - ShapeEntity: remove unreachable default branch in the constructor switch (sealed Shape makes it dead code); keep the toShape default as a DB safety check.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Shape,=>prefix on point-query lines, actual triangle/donuttoStringformats, corrected area precision).Pointgains value semantics (equals/hashCodeviaDouble.compare/Objects.hash) — a pure value type that now behaves correctly in collections, sets, and mock matchers.defaultbranch inShapeEntity(Shape)is unreachable now thatShapeis sealed (onlyCircle/Triangle/Donutplus null); thetoShape()string-based default is kept as a DB safety net.PointTest(5 assertions: equality, inequality, hashCode consistency, reflexivity, null).Verification
mvn clean test).