Thread: support OpenThread Simulator support#42841
Open
bukepo wants to merge 1 commit into
Open
Conversation
bukepo
added
the
changing-git-submodules-on-purpose
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the OpenThread Simulator (ot-ns), which is a valuable addition for evaluating Matter performance over Thread. The changes are well-structured, introducing a new otns build modifier and the necessary GN arguments and source code modifications to integrate the simulator. The implementation is mostly clean, with one opportunity for improvement to avoid a const_cast.
|
PR #42841: Size comparison from ac0beeb to 8dafcbe Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42841: Size comparison from bd1cc4d to d2dc3ad Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
bukepo
force-pushed
the
add-ot-ns
branch
3 times, most recently
from
74739f2 to
7aa538b
Compare
|
PR #42841: Size comparison from 14e806b to 7aa538b Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, qpg, realtek, stm32, telink)
|
turon
reviewed
Feb 3, 2026
| "./scripts/build/build_examples.py \ | ||
| --target linux-x64-all-clusters-no-wifi-openthread-endpoint-otns-clang \ | ||
| build | ||
| " |
Contributor
There was a problem hiding this comment.
When I run this command, it seems to just build but not run any test. Could you add a README.md that describes the basics of how to manually run the otns with Matter nodes to collect some simple metrics?
2026-02-03 13:33:07 INFO - linux-x64-all-clusters-no-wifi-openthread-endpoint-otns-clang: 35s
2026-02-03 13:33:07 INFO Total build time: 35s
Contributor
Author
There was a problem hiding this comment.
I'll probably add some explanation in ot-ns about the expectation of nodes. This commit only adds the basic support. There is additional work that needs to be done. We may add some documentation when the whole feature is complete.
gmarcosb
approved these changes
Feb 9, 2026
gmarcosb
left a comment
gmarcosb
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, but I left some comments on openthread/ot-ns#742 about the lacking flexibility of the otns app, i.e. over-dependence on $PATH + hard-coded Matter node type (instead of allowing CLI arguments) may make integration difficult
gmarcosb
reviewed
Feb 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the OpenThread Network Simulator (ot-ns) to enable Thread radio performance simulation for Matter applications. The implementation introduces an otns build modifier that depends on the openthread-endpoint modifier and includes necessary build configuration changes, command-line argument updates, and a new GitHub workflow for build validation.
Changes:
- Added ot-ns submodule and platform-specific build configuration
- Introduced
chip_enable_otnsGN build argument with corresponding dependency checks - Updated command-line interface to use generic
--thread-argsinstead of--thread-node-id
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| third_party/ot-ns/repo | Added ot-ns submodule reference |
| third_party/openthread/platforms/otns/BUILD.gn | Created build configuration for otns platform |
| src/system/BUILD.gn | Added assertion to enforce otns dependency on openthread endpoints |
| src/platform/device.gni | Declared chip_enable_otns build argument |
| src/platform/Linux/BUILD.gn | Added conditional dependency on otns vs simulation platform |
| scripts/tests/chiptest/test_definition.py | Updated test infrastructure to use new thread arguments format |
| scripts/build/testdata/all_targets_linux_x64.txt | Added otns modifier to build targets |
| scripts/build/builders/host.py | Implemented otns build configuration logic |
| scripts/build/build/targets.py | Registered otns as a build modifier |
| examples/platform/linux/Options.h | Changed thread configuration from single node ID to argument vector |
| examples/platform/linux/Options.cpp | Updated option parsing for flexible thread arguments |
| examples/platform/linux/BUILD.gn | Added conditional otns dependencies and preprocessor defines |
| examples/platform/linux/AppMain.cpp | Refactored thread initialization to support multiple arguments |
| .gitmodules | Added ot-ns submodule configuration |
| .github/workflows/build.yaml | Added build workflow for otns variant |
| self.extra_gn_options.append('chip_logging_backend="syslog"') | ||
| self.extra_gn_options.append('chip_enable_otns=true') | ||
| self.extra_gn_options.append('openthread_config_otns_enable=true') | ||
| self.extra_gn_options.append('import("//build_overrides/chip.gni")') |
There was a problem hiding this comment.
The GN import statement is being added via extra_gn_options, which is unconventional. GN imports should typically be placed in the BUILD.gn file header. Consider whether this import can be structured differently or if there's a more idiomatic way to include this configuration.
Suggested change
| self.extra_gn_options.append('import("//build_overrides/chip.gni")') |
| args.push_back(argv[0]); | ||
| for (auto & arg : LinuxDeviceOptions::GetInstance().mThreadArgs) | ||
| { | ||
| args.push_back(arg.data()); |
There was a problem hiding this comment.
Using arg.data() on temporary string objects from a vector can lead to dangling pointers. The std::string objects in mThreadArgs are not temporaries, but calling .data() returns a pointer that could become invalid if the vector is modified. Since the vector is not modified after this point and before otSysInit is called, this is safe, but consider using const_cast<char*>(arg.c_str()) for clarity about the lifetime guarantee.
Suggested change
| args.push_back(arg.data()); | |
| args.push_back(const_cast<char *>(arg.c_str())); |
gmarcosb
added a commit
to gmarcosb/connectedhomeip
that referenced
this pull request
Mar 4, 2026
…hip-tool can provision directly through OTNS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds OpenThread simulator(https://github.com/openthread/ot-ns) support. OpenThread simulator can simulate Thread radio performance, which could be used to evaluate the Matter performance under different Thread radio situations.
A
otnsmodifier is added to enable this variant.otnsdepends onopenthread-endpointmodifier.A GN build argument
chip_enable_otnsis added to control whether to enable this mode or not.Related issues
This reuses work in #42336. OpenThread simulation platform is using real time clock, while the simulator can use virtual time.
This PR depends on:
1/0openthread/openthread#12345Testing
Added a new build test just to ensure the all-clusters-app can be built with
otnsenabled. To fully validate the functionality,otnshas to be used.