Thread: unify border agent arguments#43140
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully unifies the border agent arguments in the python controller to align with chip-tool. The changes are consistent and correctly applied across all relevant files. The minor suggestion to improve the help text for one of the new arguments has been retained as it does not conflict with any existing rules.
|
PR #43140: Size comparison from 9a23d84 to 77b8d88 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Contributor
There was a problem hiding this comment.
Pull request overview
Unifies Thread Border Agent CLI/config arguments used by the Python testing controller to match chip-tool naming, and updates the commissioning plumbing accordingly.
Changes:
- Rename Border Agent CLI flags from
--border-agent-ip-addr/--border-agent-portto--thread-ba-host/--thread-ba-port. - Propagate the renamed fields through
MatterTestConfig,CommissioningInfo, and commissioning call sites. - Update provisional test script CI argument examples to use the new flags.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/python_testing/provisional/TC_SC_TC_4_1.py | Updates CI test argument example to use the new Thread BA flags. |
| src/python_testing/matter_testing_infrastructure/matter/testing/runner.py | Renames CLI args and config population for Thread MeshCoP Border Agent host/port. |
| src/python_testing/matter_testing_infrastructure/matter/testing/matter_testing.py | Passes renamed Thread BA fields into CommissioningInfo. |
| src/python_testing/matter_testing_infrastructure/matter/testing/matter_test_config.py | Renames stored config fields to thread_ba_host/thread_ba_port. |
| src/python_testing/matter_testing_infrastructure/matter/testing/commissioning.py | Renames CommissioningInfo fields and uses them for CommissionThreadMeshcop. |
andy31415
approved these changes
Feb 17, 2026
andy31415
added
the
sdk-maintainer-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit unifies the border agent arguments of the python controller to chip-tool.
Related issues
This is a follow-up of #43029.
Testing
This commit unifies the arguments and replaces all usage of the arguments. No new tests are added.