[FIX] Added missing libevent-dev dependency and install nfc required libraries#43233
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly identifies and fixes a missing dependency, libevent-dev, in the chip-cert-bins Docker image, which was causing runtime errors. The change is straightforward and resolves the issue. I have one suggestion to further optimize the change by using a more minimal package, which will help in reducing the final Docker image size.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #43233 +/- ##
=======================================
Coverage 53.74% 53.74%
=======================================
Files 1530 1530
Lines 105885 105885
Branches 13312 13312
=======================================
Hits 56903 56903
Misses 48982 48982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR #43233: Size comparison from 4500157 to af79374 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43233: Size comparison from b2c44f5 to 34427a4 Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43233: Size comparison from 100fbbd to 7581407 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43233: Size comparison from d6a189c to dba8d46 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43233: Size comparison from faec154 to 45c4e1c Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43233: Size comparison from 1029782 to 6b8b606 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
…libraries (project-chip#43233) * Added missing libevent-dev dependency * Added missing nfc_requirements.nfc.txt installation --------- Co-authored-by: Romulo Quidute Filho <romuloquidute@gmail.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
Summary
Problem
The chip-cert-bins Docker image was missing libevent-dev as a build dependency, causing build failures. When trying to run in the TH UI, the following error was shown:
Also some required module were not found:
Related issues
project-chip/certification-tool#878
project-chip/certification-tool#881
#43198
Testing
Locally tested successfully
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines