Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/matter-netman/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ define Package/matter-netman/default
CATEGORY:=Network
TITLE:=Matter Network Infrastructure Manager Daemon
URL:=https://github.com/project-chip/connectedhomeip
DEPENDS:=+libstdcpp +libatomic +libubus +libubox +jsonfilter

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency is fine, but it's a little odd as a standalone PR since nothing is pulling in any code to actually read UCI config yet? Are you implementing that code in the example app in the SDK repo? If so we can add this dependency when we also pull in a later version of the example app that has that code.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, we're using it in the example app in the SDK repo.
The idea was to already add the dependency here so that it's easier for other people to use it without having to pull it in manually, but waiting until the changes are merged in the SDK repo would also be fine IMO.

We're still finalizing the changed for the SDK repo, there is no PR for it yet.

DEPENDS:=+libstdcpp +libatomic +libubus +libubox +jsonfilter +rpcd
USERID:=matter:matter
endef

Expand Down