Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency is fine, but it's a little odd as a standalone PR since nothing is pulling in any code to actually read UCI config yet? Are you implementing that code in the example app in the SDK repo? If so we can add this dependency when we also pull in a later version of the example app that has that code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed, we're using it in the example app in the SDK repo.
The idea was to already add the dependency here so that it's easier for other people to use it without having to pull it in manually, but waiting until the changes are merged in the SDK repo would also be fine IMO.
We're still finalizing the changed for the SDK repo, there is no PR for it yet.