Frontend crashes with special character '#' filter text box by dlabrecq · Pull Request #5203 · project-koku/koku-ui

dlabrecq · 2026-05-23T23:09:06Z

Frontend crashes with special character '#' filter text box
https://redhat.atlassian.net/browse/COST-7507

https://redhat.atlassian.net/browse/COST-7507

gemini-code-assist

Code Review

This pull request updates several API query utilities and a component to enable URL encoding by setting "encode: true" in "qs.stringify" calls. The reviewer feedback indicates that explicitly setting "encode: true" is redundant as it is the default behavior of the library. It is recommended to remove this property for cleaner code and to consider centralizing the stringify configuration options into a shared constant to improve maintainability and ensure consistency across the application.

gemini-code-assist · 2026-05-23T23:11:15Z


 export function getProvidersQuery(query: ProvidersQuery) {
-  return stringify(query, { encode: false, indices: false });
+  return stringify(query, { encode: true, indices: false });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify. Removing it makes the code cleaner and more idiomatic.

Suggested change

return stringify(query, { encode: true, indices: false });

return stringify(query, { indices: false });

gemini-code-assist · 2026-05-23T23:11:15Z

 // filter_by props are converted
 export function getQuery(query: Query) {
-  return stringify(convertFilterBy(query), { encode: false, indices: false, sort: alphabeticalSort });
+  return stringify(convertFilterBy(query), { encode: true, indices: false, sort: alphabeticalSort });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify. More importantly, the repetition of these configuration options (encode, indices, sort) across multiple functions and files is a maintainability risk. Consider centralizing the qs configuration into a shared constant to ensure consistent behavior (e.g., always applying the same sorting and encoding rules) and to simplify future updates.

Suggested change

return stringify(convertFilterBy(query), { encode: true, indices: false, sort: alphabeticalSort });

return stringify(convertFilterBy(query), { indices: false, sort: alphabeticalSort });

gemini-code-assist · 2026-05-23T23:11:15Z

 // filter_by props are not converted
 export function getQueryRoute(query: Query) {
-  return stringify(query, { encode: false, indices: false, sort: alphabeticalSort });
+  return stringify(query, { encode: true, indices: false, sort: alphabeticalSort });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify.

Suggested change

return stringify(query, { encode: true, indices: false, sort: alphabeticalSort });

return stringify(query, { indices: false, sort: alphabeticalSort });

gemini-code-assist · 2026-05-23T23:11:15Z


 export function getUserAccessQuery(query: UserAccessQuery) {
-  return stringify(query, { encode: false, indices: false });
+  return stringify(query, { encode: true, indices: false });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify.

Suggested change

return stringify(query, { encode: true, indices: false });

return stringify(query, { indices: false });

gemini-code-assist · 2026-05-23T23:11:15Z

  };
  return {
-    search: stringify(searchQuery, { encode: false, indices: false }),
+    search: stringify(searchQuery, { encode: true, indices: false }),


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify.

Suggested change

search: stringify(searchQuery, { encode: true, indices: false }),

search: stringify(searchQuery, { indices: false }),

gemini-code-assist · 2026-05-23T23:11:15Z


 export function getProvidersQuery(query: ProvidersQuery) {
-  return stringify(query, { encode: false, indices: false });
+  return stringify(query, { encode: true, indices: false });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify.

Suggested change

return stringify(query, { encode: true, indices: false });

return stringify(query, { indices: false });

gemini-code-assist · 2026-05-23T23:11:16Z

 // filter_by props are converted
 export function getQuery(query: Query) {
-  return stringify(convertFilterBy(query), { encode: false, indices: false, sort: alphabeticalSort });
+  return stringify(convertFilterBy(query), { encode: true, indices: false, sort: alphabeticalSort });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify. Consider centralizing these options to improve maintainability and consistency across the application.

Suggested change

return stringify(convertFilterBy(query), { encode: true, indices: false, sort: alphabeticalSort });

return stringify(convertFilterBy(query), { indices: false, sort: alphabeticalSort });

gemini-code-assist · 2026-05-23T23:11:16Z

 // filter_by props are not converted
 export function getQueryRoute(query: Query) {
-  return stringify(query, { encode: false, indices: false, sort: alphabeticalSort });
+  return stringify(query, { encode: true, indices: false, sort: alphabeticalSort });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify.

Suggested change

return stringify(query, { encode: true, indices: false, sort: alphabeticalSort });

return stringify(query, { indices: false, sort: alphabeticalSort });

gemini-code-assist · 2026-05-23T23:11:16Z


 export function getUserAccessQuery(query: UserAccessQuery) {
-  return stringify(query, { encode: false, indices: false });
+  return stringify(query, { encode: true, indices: false });


Explicitly setting encode: true is redundant as it is the default behavior for qs.stringify.

Suggested change

return stringify(query, { encode: true, indices: false });

return stringify(query, { indices: false });

codecov · 2026-05-23T23:27:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.93%. Comparing base (88d37d5) to head (23aa8db).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5203   +/-   ##
=======================================
  Coverage   78.93%   78.93%           
=======================================
  Files         742      742           
  Lines       16830    16830           
  Branches     4050     4046    -4     
=======================================
  Hits        13284    13284           
- Misses       3351     3354    +3     
+ Partials      195      192    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Frontend crashes with special character '#' filter text box

78c5193

https://redhat.atlassian.net/browse/COST-7507

dlabrecq requested review from a team as code owners May 23, 2026 23:09

gemini-code-assist Bot reviewed May 23, 2026

View reviewed changes

Updated tests

23aa8db

koku-ui-bot approved these changes May 23, 2026

View reviewed changes

koku-ui-bot merged commit 4222cc6 into project-koku:main May 23, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Frontend crashes with special character '#' filter text box#5203

Frontend crashes with special character '#' filter text box#5203
koku-ui-bot merged 2 commits into
project-koku:mainfrom
dlabrecq:COST-7507

dlabrecq commented May 23, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

gemini-code-assist Bot May 23, 2026

Uh oh!

codecov Bot commented May 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	return stringify(query, { encode: true, indices: false });
	return stringify(query, { indices: false });

	return stringify(convertFilterBy(query), { encode: true, indices: false, sort: alphabeticalSort });
	return stringify(convertFilterBy(query), { indices: false, sort: alphabeticalSort });

	search: stringify(searchQuery, { encode: true, indices: false }),
	search: stringify(searchQuery, { indices: false }),

Conversation

dlabrecq commented May 23, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 23, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 23, 2026

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants