NCL-9585 Enable and fix swagger. #618
Merged
rnc merged 2 commits intoproject-ncl:masterfrom Mar 23, 2026
Merged
Conversation
rnc
requested review from
jomrazek and
thescouser89
and removed request for
thescouser89
jomrazek
approved these changes
Mar 23, 2026
| license = @License(name = "Apache 2.0", url = "https://www.apache.org/licenses/LICENSE-2.0.html"), | ||
| version = DA_VERSION), | ||
| servers = { @Server(url = "/da", description = "Dependency Analyzer") }, | ||
| servers = { @Server(url = "/", description = "Dependency Analyzer") }, |
Contributor
There was a problem hiding this comment.
We will need to change this in all services using it right? And possibly communicate it in case other teams use DA directly.
Contributor
Author
There was a problem hiding this comment.
Isn't that just used for the openapi definition? Although I do agree that the Quarkus app in the prior PR creates the REST API on '/rest/api...'
Contributor
Author
There was a problem hiding this comment.
Discussed offline - that @Server annotation is only for OpenAPI. However Quarkus does deploy differently so we will need to change other service configs eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #615 merged first.
Uses inspiration from @thescouser89's Dingrogu to add a similar index page.