Skip to content

fix(logout): clear localStorage after logout#390

Open
eusebiu-constantin-petu-dbk wants to merge 1 commit into
project-zot:mainfrom
eusebiu-constantin-petu-dbk:fix_logout
Open

fix(logout): clear localStorage after logout#390
eusebiu-constantin-petu-dbk wants to merge 1 commit into
project-zot:mainfrom
eusebiu-constantin-petu-dbk:fix_logout

Conversation

@eusebiu-constantin-petu-dbk
Copy link
Copy Markdown
Contributor

clearing localStorage before making logout call
makes axios to not send session cookies to
backend so it can not handle the request and returns 500.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

clearing localStorage before making logout call
makes axios to not send session cookies to
backend so it can not handle the request and returns 500.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 2, 2023

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.09%. Comparing base (fad5572) to head (3a41372).
⚠️ Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
src/utilities/authUtilities.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   86.73%   86.09%   -0.65%     
==========================================
  Files          53       53              
  Lines        1553     1553              
  Branches      416      406      -10     
==========================================
- Hits         1347     1337      -10     
- Misses        193      203      +10     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raulkele
Copy link
Copy Markdown
Collaborator

@andaaron @peusebiu Is this still needed?
I remember when it was first opened it fixed an authentication related bug.

@andaaron
Copy link
Copy Markdown
Contributor

I do not know, I was travelling while this issue was opened, and did not discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants