prometheus: fix race between metric export and test fetch#1051
Merged
Conversation
The interface-stats integration test fetches /metrics as soon as the HTTP server is reachable, but exportMetrics() may not have completed its first cycle by that point. This race was exposed by f4674d5 which removed implicit delays (waitForStatsSocket + statsclient.Connect) that previously masked the timing issue. Added a new helper function fetchMetricsUntilPresent() to retry the HTTP fetch until the expected metric name appears in the response body (or a timeout expires). Applied it to all tests that assert metric presence. Signed-off-by: Aritra Basu <aritrbas+gh@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the flaky Prometheus integration tests that started failing after f4674d5 - stats-segment refactor that removed implicit delays (
waitForStatsSocket+statsclient.Connect) which masked a race condition.fetchMetricsUntilPresent()helper that polls/metricsuntil the expected metric name appears, replacing the flakyfetchMetricsWithRetry()mehcanism which returned on the first successful HTTP response regardless of content.time.Sleep(2s)from pod test.