Add espejote-managed additional facts - #117
Merged
Merged
Conversation
DebakelOrakel
marked this pull request as ready for review
July 8, 2026 07:34
DebakelOrakel
changed the title
DebakelOrakel
force-pushed
the
managed-additional-facts
branch
from
July 8, 2026 08:05
a3c131b to
ef55b38
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
HappyTetrahedron
commented
Jul 8, 2026
HappyTetrahedron
left a comment
HappyTetrahedron
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM. I opened the PR so I can't approve it ^^
| <1> Label the `ConfigMap` so it's picked up by the `ManagedResource`, see xref:references/parameters.adoc#_additional_facts_config_label[Parameters] for the values. | ||
| <2> The `ConfigMaps` will get sorted by their name before merging. | ||
| <3> Apply the `ConfigMap` to the `syn` namespace. | ||
| <4> Use the key `spec` for your configuration |
DebakelOrakel
force-pushed
the
managed-additional-facts
branch
from
July 8, 2026 08:39
ef55b38 to
1144e55
Compare
DebakelOrakel
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.