[Hackathon] fix(nest-plugins-reference): register missing reference plugin entry …#179
Open
shreyad2806 wants to merge 2 commits into
Open
[Hackathon] fix(nest-plugins-reference): register missing reference plugin entry …#179shreyad2806 wants to merge 2 commits into
shreyad2806 wants to merge 2 commits into
Conversation
…points The reference package only exposed a handful of plugins as entry points (memory/lww_register, privacy/hybrid_x25519, datafacts/cid_facts, and the failure detectors). The remaining plugins were only reachable through the built-in fallback in nest-core, which is not the documented discovery path. Add entry-point declarations for every plugin listed in the built-in fallback so that the PluginRegistry discovers them via the standard install-time mechanism documented in CONTRIBUTING.md. Also add a regression test in nest-core that fails if a built-in plugin is not backed by an entry point, preventing the two registries from drifting out of sync again. Closes: nothing
shilpa-kulkarni-14
self-requested a review
July 10, 2026 16:33
Collaborator
|
@shreyad2806 plz resolve conflicts |
Author
|
Fixed the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference package only exposed a handful of plugins as entry points (memory/lww_register, privacy/hybrid_x25519, datafacts/cid_facts, and the failure detectors). The remaining plugins were only reachable through the built-in fallback in nest-core, which is not the documented discovery path.
Add entry-point declarations for every plugin listed in the built-in fallback so that the PluginRegistry discovers them via the standard install-time mechanism documented in CONTRIBUTING.md.
Also add a regression test in nest-core that fails if a built-in plugin is not backed by an entry point, preventing the two registries from drifting out of sync again.