fix(trust): ignore self-reports in ScoreAverageTrust#201
Open
owenamurray04 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ScoreAverageTrust.report()never checksevidence.reporter, so an agent canfile positive evidence about itself to inflate its own score, or dilute genuine
negative reports back toward neutral.
Change
report()ignores evidence whereevidence.reporter == agent. All otherreports behave as before. Matches
bonded_trust, which already skipsself-reports when scoring.
Tests
test_self_report_is_ignored: ten positive self-reports leave the agent atthe never-rated default. Fails on main (score=1.0, sample_count=10).
test_self_report_does_not_dilute_others: a self-boost cannot offset agenuine negative report. Fails on main (score=0.5, sample_count=2).
Verification
make ci-localpasses all five gates (pytest: 1276 passed, 1 skipped).