Open
Conversation
roidelapluie
force-pushed
the
gha
branch
4 times, most recently
from
050bce4 to
a3f3ef2
Compare
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Member
Author
jan--f
approved these changes
Jan 26, 2023
Contributor
jan--f
left a comment
jan--f
left a comment
There was a problem hiding this comment.
This looks good to me.
I'd propose the same change as for prometheus/influxdb_exporter#125: to split up the ci and release workflows. See roidelapluie#1 for the proposed change and https://github.com/jan--f/consul_exporter/pull/1 for how it looks in a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@o11y.eu