Update build constraints for loong64 and s390x, Compatible with lower versions of go compiler#626
Open
fangwentong wants to merge 1 commit intoprometheus:masterfrom
Open
Update build constraints for loong64 and s390x, Compatible with lower versions of go compiler#626fangwentong wants to merge 1 commit intoprometheus:masterfrom
fangwentong wants to merge 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: fangwentong <fangwentong2012@gmail.com>
Member
|
Not sure we want/need to support go 1.16. Why do you need to compile it with that old version? @SuperQ wdyt? |
Member
|
As of today this library requires Go 1.20 and newer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go1.16 cannot recognize the loong64 instruction set architecture, and an error will occur during compilation. This MR explicitly specifies the instruction set build constraints in the source file.
When running on linux/amd64, got the following error