Provide option for tab to apply completion#390
Open
mskar wants to merge 1 commit intoprompt-toolkit:mainfrom
Open
Provide option for tab to apply completion#390mskar wants to merge 1 commit intoprompt-toolkit:mainfrom
mskar wants to merge 1 commit intoprompt-toolkit:mainfrom
Conversation
c3b2aee to
1b4fc38
Compare
6afc560 to
f1721f4
Compare
e8c3bf3 to
7dd79e0
Compare
improve completion when completion menu is not showing improve apply completion with enter improve completion with enter in ptpython
7dd79e0 to
d7e4511
Compare
Author
|
I split the original feature into 5 independent features.
These features can be combined. Is 5 settings too many? Please let me know if any of the settings should be renamed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #387, I requested a feature that adds parentheses after functions completed with
TaborEnter.This pull request implements the feature I requested (function completion with added parentheses), but also strives to make autocompletion work like in the VSCode Python extension and PyCharm. In VSCode and PyCharm,
Tabapplies completion instead of cycling through completion options, like in bash or zsh.TLDR:
previous behavior:
Tabcycles completionproposed behavior:
Tabapplies completionCurrently, this feature is enabled by default, but it can be disabled using by adding
to
config.py.For more information, please take a look at this comment in #387.
To install ptpython with the
tab_apply_completionfeature, runChanges:
Changed: when triggering completion with
Tab, insert text that all options have in commonChanged: use
Tabto accept only option or accept selectedChanged: do not move through options with not
TabandShift-TabUnchanged: use
Enterto accept if completion menu is showingUnchanged: move through options with
c-nandc-pUnchanged: cancel completion with
c-g