Chore/shared proofkit skills by eluce2 · Pull Request #205 · proofsh/proofkit

eluce2 · 2026-03-23T15:05:58Z

Summary by CodeRabbit

Chores

Streamlined CI/CD workflows to improve release automation efficiency and consistency
Added changeset validation for pull requests that modify releasable code
Enhanced preview package publishing for development-related changes through reusable workflow infrastructure

vercel · 2026-03-23T15:06:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
proofkit-docs	Error		Mar 23, 2026 3:06pm

changeset-bot · 2026-03-23T15:06:04Z

⚠️ No Changeset found

Latest commit: 3504934

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-23T15:10:00Z

📝 Walkthrough

Walkthrough

Introduces changeset enforcement in pull requests to detect changes in releasable code paths, and refactors release and publish workflows into reusable patterns that conditionally trigger based on changeset detection.

Changes

Cohort / File(s)	Summary
Changeset Enforcement `.github/workflows/changeset-enforcement.yml`	New workflow that runs on PRs to detect changes in releasable paths (`apps/`, `packages/`, config files) and enforces presence of changesets via `pnpm changeset status`.
Release and Publish Workflow Refactoring `.github/workflows/publish-any-commit-reusable.yml`, `.github/workflows/continuous-release.yml`, `.github/workflows/release.yml`	Extracted common lint/typecheck/test/build/publish job logic into reusable workflow. Simplified continuous-release to delegate to reusable workflow. Added conditional publish job in release workflow gated on changeset detection output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

update formatting #42: Adds .changeset file and package updates that supply the changeset artifacts enforced by the new changeset-enforcement workflow.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Chore/shared proofkit skills' is vague and does not clearly convey what changes are being made. The PR involves significant GitHub Actions workflow refactoring (changeset enforcement, CI/CD pipeline restructuring, and release automation), but the title uses generic/non-descriptive terminology that doesn't communicate the primary changes.	Consider a more descriptive title that reflects the main changes, such as 'Refactor CI/CD workflows: add changeset enforcement and reusable publish workflow' or 'Add changeset enforcement and reorganize GitHub Actions workflows'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Important

Merge conflicts detected (Beta)

❌ Error resolving conflicts.

Resolve merge conflict in branch chore/shared-proofkit-skills

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/shared-proofkit-skills

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

.github/workflows/changeset-enforcement.yml (1)
40-49: Inconsistent pnpm setup approach compared to other workflows.

This workflow uses pnpm/action-setup@v4 while the other workflows in this PR use corepack enable. Both approaches work, but mixing them could lead to version mismatches if the repository's packageManager field in package.json specifies a different pnpm version than what pnpm/action-setup installs by default.

Consider using the same approach (corepack enable) for consistency across all workflows, which respects the version pinned in package.json.
♻️ Suggested change for consistency
      - name: Setup pnpm
        if: steps.scope.outputs.requires_changeset == 'true'
-       uses: pnpm/action-setup@v4
+       run: corepack enable

      - name: Setup Node.js
        if: steps.scope.outputs.requires_changeset == 'true'
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/changeset-enforcement.yml around lines 40 - 49, Replace
the heterogeneous pnpm setup by removing the pnpm/action-setup@v4 step and using
the same "corepack enable" approach as other workflows: update the "Setup pnpm"
step (and ensure "Setup Node.js" remains) to run corepack enable so pnpm version
respects package.json's packageManager; specifically modify the steps titled
"Setup pnpm" and the adjacent "Setup Node.js" in changeset-enforcement.yml to
use corepack enable instead of pnpm/action-setup@v4 to keep behavior consistent
across workflows.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/changeset-enforcement.yml:
- Around line 40-49: Replace the heterogeneous pnpm setup by removing the
pnpm/action-setup@v4 step and using the same "corepack enable" approach as other
workflows: update the "Setup pnpm" step (and ensure "Setup Node.js" remains) to
run corepack enable so pnpm version respects package.json's packageManager;
specifically modify the steps titled "Setup pnpm" and the adjacent "Setup
Node.js" in changeset-enforcement.yml to use corepack enable instead of
pnpm/action-setup@v4 to keep behavior consistent across workflows.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8b0774f1-7f07-474d-be6d-8346587ca3c8

📥 Commits

Reviewing files that changed from the base of the PR and between 94d6068 and 3504934.

📒 Files selected for processing (4)

.github/workflows/changeset-enforcement.yml
.github/workflows/continuous-release.yml
.github/workflows/publish-any-commit-reusable.yml
.github/workflows/release.yml

coderabbitai · 2026-03-23T15:11:37Z

❌ An unexpected error occurred while resolving merge conflicts:

Resource not accessible by integration - https://docs.github.com/rest/git/trees#create-a-tree

Eric Luce added 2 commits March 19, 2026 18:17

ci: enforce changesets on pull requests

b9e24bc

ci: reuse publish-any-commit checks for release PRs

3504934

coderabbitai bot reviewed Mar 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/shared proofkit skills#205

Chore/shared proofkit skills#205
eluce2 wants to merge 2 commits intomainfrom
chore/shared-proofkit-skills

eluce2 commented Mar 23, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Mar 23, 2026

Uh oh!

changeset-bot bot commented Mar 23, 2026

Uh oh!

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 inconclusive)

Merge conflicts detected (Beta)

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

eluce2 commented Mar 23, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Chores

Uh oh!

vercel bot commented Mar 23, 2026

Uh oh!

changeset-bot bot commented Mar 23, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 inconclusive)

Merge conflicts detected (Beta)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

eluce2 commented Mar 23, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 23, 2026 •

edited

Loading

coderabbitai bot commented Mar 23, 2026 •

edited

Loading